Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vertx dep on panache-common #2028

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Remove vertx dep on panache-common #2028

merged 1 commit into from
Apr 12, 2019

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Apr 12, 2019

Was there by mistake, not used

Fixes #2026

Was there by mistake, not used
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the original reason to have the dependency?

@FroMage
Copy link
Member Author

FroMage commented Apr 12, 2019

Probably happened during prototyping when panache-rx was mixed with it.

@cescoffier cescoffier added this to the 0.14.0 milestone Apr 12, 2019
@cescoffier cescoffier added kind/bug Something isn't working area/panache labels Apr 12, 2019
@gsmet gsmet modified the milestones: 0.14.0, 0.13.2 Apr 12, 2019
@gsmet gsmet merged commit 8fff910 into quarkusio:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panache kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panache-common incorrectly depends on vertx
3 participants